snapshots: send highest manifest slot #5932
Open
+759
−222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-slot-message
branch
7 times, most recently
from
186fa5b to
3bdaafc
Compare
cali-jumptrading
changed the title
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-slot-message
branch
from
3bdaafc to
950ec6b
Compare
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-slot-message
branch
4 times, most recently
from
aa7352d to
875936e
Compare
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-slot-message
branch
from
875936e to
2673ae1
Compare
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-slot-message
branch
from
2673ae1 to
8af7620
Compare
mmcgee-jump
reviewed
Aug 19, 2025
| struct pollfd * pfd = &ssping->fds[ i ]; | ||
| if( FD_UNLIKELY( pfd->revents & (POLLERR|POLLHUP) ) ) { | ||
| unping_peer( ssping, peer_pool_ele( ssping->pool, ssping->fds_idx[ i ] ), now ); | ||
| continue; | ||
| } | ||
|
|
||
| if( FD_LIKELY( pfd->revents & POLLOUT ) ) { | ||
| struct icmphdr icmp_hdr = (struct icmphdr){ |
There was a problem hiding this comment.
The more I think about this the more I think I was wrong about using HTTP server ACK response time. Using ping time is actually probably correct for the pinger because we are just trying to find the server in the closest data center. Whether they had some latency spike on the HTTP server when we sent request probably doesn't matter too much
mmcgee-jump
reviewed
Aug 19, 2025
| #define FD_SSMSG_DONE (2) /* Indicates the snapshot is fully loaded and tiles are shutting down */ | ||
| #define FD_SSMSG_MANIFEST_FULL (0) /* A snapshot manifest message from the full snapshot */ | ||
| #define FD_SSMSG_MANIFEST_INCREMENTAL (1) /* A snapshot manifest message from the incremental snapshot */ | ||
| #define FD_SSMSG_HIGHEST_MANIFEST_SLOT (2) /* The highest manifest slot so far, guaranteed to be monotonically increasing */ |
There was a problem hiding this comment.
Comment doesn't seem right. Why would this be monotonically increasing?
There was a problem hiding this comment.
This should really be
EXPECTED_MANIFEST_SLOT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repair can start before the snapshot is fully loaded if the snapshot tiles send the highest manifest slot seen so far. The highest manifest slot is typically the incremental snapshot slot, but can be the full snapshot slot if incremental snapshots are disabled. The highest manifest slot is guaranteed to be monotonically increasing. It is sent by the snaprd tile when a snapshot peer is selected.
Makes use of #5777 to resolve snapshots for each peer.